Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Keycloak examples #311

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Update Keycloak examples #311

merged 1 commit into from
Nov 17, 2023

Conversation

guicassolato
Copy link
Contributor

Update AuthPolicy examples that use the latest version of Keycloak from https://github.com/Kuadrant/authorino-examples.

Follow-up on Kuadrant/authorino-examples#35

@guicassolato guicassolato requested a review from a team as a code owner November 16, 2023 21:31
@guicassolato guicassolato self-assigned this Nov 16, 2023
@guicassolato guicassolato added kind/bug Something isn't working area/doc Improvements or additions to documentation target/current size/small labels Nov 16, 2023
@guicassolato guicassolato force-pushed the update-keycloak-examples branch from 1a97414 to 9114193 Compare November 16, 2023 21:33
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #311 (9114193) into main (d6e0604) will decrease coverage by 1.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   65.21%   64.13%   -1.08%     
==========================================
  Files          35       35              
  Lines        3806     3806              
==========================================
- Hits         2482     2441      -41     
- Misses       1137     1166      +29     
- Partials      187      199      +12     
Flag Coverage Δ
integration 69.30% <ø> (-2.02%) ⬇️
unit 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.41% <ø> (ø)
controllers (i) 69.30% <ø> (-2.02%) ⬇️

see 9 files with indirect coverage changes

Copy link
Member

@alexsnaps alexsnaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this even breaking the build?!
I'm all for ignoring this, and merging!

@alexsnaps alexsnaps mentioned this pull request Nov 16, 2023
4 tasks
@guicassolato
Copy link
Contributor Author

How is this even breaking the build?!

It's not. It only fixes the failing 4th "user guide tried" of #303.

@guicassolato guicassolato merged commit 2149a91 into main Nov 17, 2023
20 of 21 checks passed
@guicassolato guicassolato deleted the update-keycloak-examples branch November 17, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Improvements or additions to documentation kind/bug Something isn't working size/small
Projects
Archived in project
Status: To test
Development

Successfully merging this pull request may close these issues.

2 participants