-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update headings and some format fixes #1125
update headings and some format fixes #1125
Conversation
charts/kuadrant-operator/README.md
Outdated
autoscaleEnabled: false | ||
EOF | ||
``` | ||
```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the 4 space indent here.
Are the backticks not enough to render the code block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does render as is but the numbered headings are producing an error then. this change isn't essential tho so if you'd prefer to have it removed I can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny you should mention the numbered headings.
I'm proposing we avoid numbered lists in this style guide PR.
Personally, I think that should extend to numbering of headers as well, for the same reason.
re: the spaces on the code blocks,
for consistency would you mind if we removed the indentation, to align with the usage docs in https://squidfunk.github.io/mkdocs-material/reference/code-blocks/#usage
charts/kuadrant-operator/README.md
Outdated
|
||
### Install dependencies | ||
[Envoy](https://www.envoyproxy.io/docs/envoy/latest/start/start) is also an option as a gateway provider, **Steps Coming soon!** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Envoy](https://www.envoyproxy.io/docs/envoy/latest/start/start) is also an option as a gateway provider, **Steps Coming soon!** | |
[Envoy Gateway](https://gateway.envoyproxy.io/) is also an option as a gateway provider, **Steps Coming soon!** |
e9f96d1
to
74e5201
Compare
Thanks @laurafitzgerald |
Signed-off-by: Laura Fitzgerald <[email protected]>
74e5201
to
97e2e66
Compare
Changing from using the word pre-requisites as this might imply to the user when they are reading that they are responsible for those things when the steps needed to install are provided in the guide.
Also some small formatting fixes.