docs: Fix incorrect geo code in DNS user guide #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As well as updating the docs can we add CEL validation to policy, so the user can't apply the a policy to the cluster with invalid codes? |
Probably could add a CEL validation for codes with the "GEO-" prefix since we have a provider agnostic list for those that we define. That said, its not something i intend to look into now, or add to this PR. Created an issue for it #1113 |
thomasmaas
approved these changes
Jan 14, 2025
GEO-US -> US Only the following codes will be accepted with a "GEO-" prefix: ``` AWS_CONTINENT_CODE_AFRICA = "AF" AWS_CONTINENT_CODE_ANTARTICA = "AN" AWS_CONTINENT_CODE_ASIA = "AS" AWS_CONTINENT_CODE_EUROPE = "EU" AWS_CONTINENT_CODE_OCEANIA = "OC" AWS_CONTINENT_CODE_NORTH_AMERICA = "NA" AWS_CONTINENT_CODE_SOUTH_AMERICA = "SA" ``` Signed-off-by: Michael Nairn <[email protected]>
mikenairn
force-pushed
the
fix-dns-docs
branch
from
3721f13 to
8f1bae4
Compare
mikenairn
changed the title
mikenairn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEO-US -> US
Only the following codes will be accepted with a "GEO-" prefix: