Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove multiple network resources with identical hostnames limitation #1032

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Nov 19, 2024

Description

Closes: #702

#702 has been fixed and with the refactor to effective policies the limitatation for multiple network resources with identical hostnames no longer applies for Auth and RateLimit policy

Verification

kubectl apply -f - <<EOF
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: other
spec:
  parentRefs:
  - name: kuadrant-ingressgateway
    namespace: gateway-system
  hostnames:
  - api.toystore.com
  rules:
  - matches: # rule-1
    - method: GET
      path:
        type: PathPrefix
        value: "/other"
    backendRefs:
    - name: toystore
      port: 80
EOF
  • Curling this path should give a 403 as it's protected by the GW policy
 curl -H 'Host: api.toystore.com'  http://$GATEWAY_URL/other -i

@Boomatang
Copy link
Contributor

@KevFan when you get a chance can you rebase this. I was going to review it.

@KevFan
Copy link
Contributor Author

KevFan commented Jan 8, 2025

@Boomatang rebased 👍

Boomatang
Boomatang previously approved these changes Jan 27, 2025
Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me

@KevFan
Copy link
Contributor Author

KevFan commented Jan 27, 2025

Rebased to only account for RLP doc as Auth doc was done as part of #1136

Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, looks even better now.

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably review this entire doc along the lines of #1136, but removing this limitation from it is a good start. Thanks @KevFan!

@KevFan KevFan added this pull request to the merge queue Jan 27, 2025
Merged via the queue into Kuadrant:main with commit 6cb70c2 Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Improvements or additions to documentation size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthPolicy does not recover from error state automatically if root cause of the error got fixed
3 participants