Skip to content

Commit

Permalink
fix: Google dns provider metrics name key
Browse files Browse the repository at this point in the history
The google providers instrumented client has the name "google" and not "gcp", so no google provider metrics are currently appearing on the grafana dashboard https://github.com/Kuadrant/dns-operator/blob/main/internal/provider/google/google.go#L131

Signed-off-by: Michael Nairn <[email protected]>
  • Loading branch information
mikenairn committed Jan 21, 2025
1 parent 36ad552 commit a5376a1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions examples/dashboards/dns-operator.json
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@
"uid": "${datasource}"
},
"editorMode": "code",
"expr": "histogram_quantile(0.99, sum by(le, client) (rate(http_client_request_latency_seconds_bucket{client=~\"aws|gcp|azure\",code=\"200\"}[15m])))",
"expr": "histogram_quantile(0.99, sum by(le, client) (rate(http_client_request_latency_seconds_bucket{client=~\"aws|google|azure\",code=\"200\"}[15m])))",
"legendFormat": "{{client}}:99%ile",
"range": true,
"refId": "A"
Expand All @@ -480,7 +480,7 @@
"uid": "${datasource}"
},
"editorMode": "code",
"expr": "histogram_quantile(0.95, sum by(le, client) (rate(http_client_request_latency_seconds_bucket{client=~\"aws|gcp|azure\",code=\"200\"}[15m])))",
"expr": "histogram_quantile(0.95, sum by(le, client) (rate(http_client_request_latency_seconds_bucket{client=~\"aws|google|azure\",code=\"200\"}[15m])))",
"hide": false,
"legendFormat": "{{client}}:95%ile",
"range": true,
Expand Down Expand Up @@ -571,7 +571,7 @@
"uid": "${datasource}"
},
"editorMode": "code",
"expr": "sum by (client, code) (rate(http_client_requests_total{client=~\"aws|gcp|azure\"}[15m]))",
"expr": "sum by (client, code) (rate(http_client_requests_total{client=~\"aws|google|azure\"}[15m]))",
"hide": false,
"legendFormat": "{{client}}:{{code}}",
"range": true,
Expand Down

0 comments on commit a5376a1

Please sign in to comment.