Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom operator namespace for helm install #216

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

guicassolato
Copy link
Collaborator

@guicassolato guicassolato commented Sep 25, 2024

Removes the creation of the authorino-operator namespace from the chart to let it be handled by Helm instead.

Proposed at #202 (comment)

Contains commits of #215

@guicassolato guicassolato self-assigned this Sep 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.78%. Comparing base (67174c9) to head (9467221).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files           2        2           
  Lines         785      785           
=======================================
  Hits          485      485           
  Misses        249      249           
  Partials       51       51           
Flag Coverage Δ
unit 61.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eshepelyuk
Copy link

Hello

I am sorry, is there any ETA for this PR to be merged / released ?

@guicassolato guicassolato marked this pull request as ready for review September 27, 2024 08:25
@guicassolato guicassolato requested a review from a team September 27, 2024 08:25
didierofrivia
didierofrivia previously approved these changes Sep 30, 2024
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

Removes the creation of the `authorino-operator` namespace from the chart to let it be handled by Helm instead.

Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
@guicassolato guicassolato force-pushed the helm-operator-namespace branch from 4afb125 to 9467221 Compare September 30, 2024 15:31
@guicassolato guicassolato merged commit b9f6460 into main Sep 30, 2024
9 of 11 checks passed
@guicassolato guicassolato deleted the helm-operator-namespace branch September 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants