[fix] simplifies test assertions #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
force-pushed
the
gomega-assertios
branch
from
a08fc6d to
b50422c
Compare
This change reworks functions called by Gomega's `Eventually` polling wrapper to return actual errors instead of return boolean expressions. With this approach, error messages are more explicit, pointing to the exact error that unexpectedly occurred. Signed-off-by: bartoszmajsak <[email protected]>
bartoszmajsak
force-pushed
the
gomega-assertios
branch
from
b50422c to
5b75f7f
Compare
guicassolato
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reworks functions called by Gomega's
Eventuallypolling wrapper to return actual errors instead of return boolean expressions.With this approach, error messages are more explicit, pointing to the exact error that unexpectedly occurred.
Note
I also removed dead func