Added support as Swift Package #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iPads or MacCatalyst requires an anchor point for presentation
Define source view and source rect for the activity popover, case .pad idioms
|
Can anybody merge this, please? |
|
@OlegEremenko991 does #246 solves your problem? |
|
Can you re-open a new PR and only have changes related to the Package? I can see that there are changes to |
|
cc @tc-sgupta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues with Carthage and the new xcode12. It looks like that Carthage currently no more is usable with Xcode12 and iOS simulator. When you build the frameworks with 'carthage update' or 'carthage build' there comes an error. A deeper look says "have the same architectures (arm64) and can't be in the same fat output file" So the iOS Simulator build is missing in the framework. This already is discussed as issue here Carthage/Carthage#3019 and here ashleymills/Reachability.swift#370
My workarround was just to move from carthage to Swift Packages. I found out that is really easy to provide an existing iOS framework as Swift Package. Just create a fork of it, put there a configured Package.swift file into the root folder, double click it in finder to open it in Xcode as a SWIFT PACKAGE PROJECT !!! - now just add/change the path to the source files in the Package.swift file. When you could build the project, all is fine and push it to your repo - thats it. For this works.
Maybe you want to add Swift Package support ?