Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FluidDynamicsHydraulicsApplication] Adding new hydraulic utilities; inflow detection and artificial viscosity. #13061

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

uxuech
Copy link
Contributor

@uxuech uxuech commented Jan 29, 2025

📝 Description
"In this PR, we add two new methods to the hydraulic utilities:

  • Moving the artificial viscosity calculation from the hydraulic solver to this utility to improve computational cost.
  • Avoiding inflow into the domain. In the future, new outlet processes will be added, and there is an option where we prevent fluid from entering the domain, allowing only tangential movement to the normal of the model part where the outlet condition is applied.

Reminder for the future: The test for the artificial viscosity calculation is performed in the test of the TwoFluidNavierStokesFractional element within the Calculate method, where the artificial viscosity is actually computed.
Its application in Python is tested in the solver test. Therefore, adding an extra test to evaluate the method itself within the utility is not considered necessary."

🆕 Changelog

  • Export the methods to Python to enable their use in the outlet processes.
  • Test the new utilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant