Added printable percent values for a series. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the clockwise gauge changes from niosega
Added the clockwise gauge changes from niosega
Revert "Added the clockwise gauge changes from niosega"
Revert "Added the clockwise gauge changes from niosega"
Revert "Revert "Added the clockwise gauge changes from niosega""
Conflicts: pygal/test/test_gauge.py
Except too broad fixed
Added ccwise test
… the kwarg was put in correctly.
… the bar module as an idea as how we might get it to print the values, also tried to write a test that would only pass if we get it to print out in test_bar but I couldn't get it to recognise the print_values **kwarg. Everything I did is commmented out to make sure I didn't break the code
modified: pygal/config.py modified: pygal/graph/bar.py modified: pygal/graph/graph.py modified: pygal/test/test_bar.py modified: pygal/view.py
Conflicts: pygal/graph/bar.py
a comparison to to differentiate between print values, and print percent.
Conflicts: pygal/config.py
Fixed the printing a little bit.
Fingers crossed
Font Ratio and Graph Loops Update, incorporating Feargal's testing and Jace's Scaling
|
Thanks for your hard work! I won't merge this PR as is for several reasons:
If you address these problems I will gladly merge your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My group found out that values can already be printed atop bar graphs, but added functionality to print the percentage of a series total. This closes #214.