Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3주차 미션 / 서버 3조 김상균 #2

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ksg1227
Copy link

@ksg1227 ksg1227 commented Oct 3, 2024

No description provided.

Copy link
Member

@hamhyeongju hamhyeongju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 잘 봤습니다!
리팩토링부터 테스트까지 깔끔하게 잘 작성해주셔서 수월하게 코드 리뷰 드릴 수 있었네요!
하지만 객체에 적절한 역할을 부여하고 메서드가 그 역할에 맞게 하나의 일만 할 수 있도록 코드 설계에 관해 좀 더 생각해보시면 좋을 것 같습니다!
코드 리뷰 확인하시고 이따 추가로 올라갈 구현 코드 확인하시면서 비교해보시면 좋을 것 같습니다. 수고 많으셨습니다!

// form.html, login.html, login_failed.html 에서는 list.html 에 forward 방식으로 바로 접근한다. 따라서 검증 로직을
// 이 위치에도 한 번 더 적용해주었다.
if (request.getUrl().equals(USER_LIST_HTML.getUrl())) {
boolean login = request.checkLogin();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그인 여부를 확인하는게 HttpRequest의 역할일까요?? 😅

src/main/java/controller/LoginController.java Show resolved Hide resolved
src/main/java/http/request/HttpRequest.java Show resolved Hide resolved
src/main/java/http/request/HttpRequestHeader.java Outdated Show resolved Hide resolved
src/main/java/http/response/HttpResponse.java Outdated Show resolved Hide resolved
src/main/java/http/response/HttpResponse.java Show resolved Hide resolved
src/main/java/mapper/RequestMapper.java Outdated Show resolved Hide resolved
src/main/java/mapper/RequestMapper.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants