3주차 미션 / 서버 2조 황정안 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twkwon0417
reviewed
Oct 7, 2024
| if (line.equals("")) { | ||
| break; | ||
| } | ||
| if (line.startsWith("Cookie:")) { |
Comment on lines
+206
to
+207
| dos.writeBytes( CONTENT_TYPE.getHeader()+": "+TEXT_CSS.getHeader()+"\r\n"); | ||
| dos.writeBytes( CONTENT_LENGTH.getHeader()+": "+ lengthOfBodyContent + "\r\n"); |
| boolean isLogined = false; | ||
| if (cookieHeader != null) { | ||
| Map<String, String> cookies = HttpRequestUtils.parseCookies(cookieHeader.split(": ")[1]); | ||
| isLogined = "true".equals(cookies.get("logined")); |
| dos.writeBytes( SET_COOKIE.getHeader() +": " +"logined=true\r\n"); | ||
|
|
||
| dos.writeBytes("\r\n"); | ||
| dos.flush(); |
There was a problem hiding this comment.
flush 후 stream 닫아 주세요!!
try-with-resource로 관리할수도 있습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
현재 리팩토링 중 enum까지 완료하였고 계속 업로드 하겠습니다