chore(ci): apply fixes to the ngx_wasm_module update workflow #12134
+35
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
2 times, most recently
from
ba8584c to
7fd2cd7
Compare
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
from
7fd2cd7 to
54884bd
Compare
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
2 times, most recently
from
cde8f99 to
2f5f0e2
Compare
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
from
9cfcb29 to
15a069b
Compare
flrgh
changed the title
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
2 times, most recently
from
1f582d8 to
66651ba
Compare
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
4 times, most recently
from
853353a to
fb26915
Compare
locao
added
the
pr/ready (but hold merge)
|
I added the "hold merge" label to remind us to test the personal token instead of |
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
2 times, most recently
from
ab29d5a to
95d65a2
Compare
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
from
95d65a2 to
0fc944f
Compare
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
from
0fc944f to
b003bd6
Compare
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
from
b003bd6 to
a3fcc56
Compare
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
from
6db1d42 to
6bee653
Compare
flrgh
force-pushed
the
fix/ngx_wasm_module_updates
branch
from
6bee653 to
69f18ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
cherry-pick kong-eelabel to created PRsteam-gateway-botwhy create the PR as draft and assign to @flrgh?
There is a big flaw in all of this in that PRs created using GITHUB_TOKEN do not trigger the integration test suite. For the life of me, I cannot figure out a fully-automated workaround:
We don't want maintainers to merge the dependency update without running the tests, so for now, the PR is created as a draft as a safeguard against somebody seeing that the PR is green and merging it anyways. The PR body will include a checklist item reminding maintainers to ensure the test suite has been triggered: