Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): restrict maximum tensorflow version to stay below 2.16.0 #92

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

dasmy
Copy link
Contributor

@dasmy dasmy commented Mar 22, 2024

Otherwise tf.keras.callbacks.experimental is not available, see https://www.tensorflow.org/api_docs/python/tf/keras/callbacks/experimental/BackupAndRestore

@Kohulan
Copy link
Owner

Kohulan commented Mar 22, 2024

Hi @dasmy ,

I was exactly expecting this. I think it should be set to be below 2.15.0.

@Kohulan Kohulan changed the base branch from master to development March 22, 2024 09:13
@Kohulan Kohulan changed the title Restrict maximum tensorflow version to stay below 2.16.0 chore(dependencies): restrict maximum tensorflow version to stay below 2.16.0 Mar 22, 2024
@Kohulan Kohulan merged commit e865605 into Kohulan:development Mar 22, 2024
2 of 3 checks passed
@dasmy
Copy link
Contributor Author

dasmy commented Mar 22, 2024

Thanks for your comment. As far as I understand the above documentation link above, 2.15 still included the experimental namespace while it was removed in 2.16.

For me, the version including this commit at least does not complain any more on my Mac.
Still did not test end to end as I am currently having other, unrelated difficulties.

A proper fix would have been to require tensorflow>=2.15 and to drop the experimental namespace. However, not knowing the code and potential side-effects very well, I did not dare to try that, yet.

@Kohulan
Copy link
Owner

Kohulan commented Mar 25, 2024

Thanks for the information. So far I have trained and tested with TensorFlow==2.15.0 and all does work fine. So I would stick with it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants