Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: The big cleanup #24200

Merged
merged 21 commits into from
Oct 14, 2024
Merged

feat!: The big cleanup #24200

merged 21 commits into from
Oct 14, 2024

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Oct 3, 2024

See #24198

@Koenkk Koenkk marked this pull request as draft October 3, 2024 19:22
@Nerivec
Copy link
Collaborator

Nerivec commented Oct 4, 2024

For a2237ed

Removed:

  • mqtt:
    • bridge/log
    • bridge/(bind|unbind)/
    • bridge/group/(.+)/(remove|add|remove_all)
    • bridge/group/remove_all
    • bridge/networkmap/${data.message}
    • bridge/ota_update/
  • update_available from OTA update payload/state
  • default group converters (always use members converters instead)
  • retrieve_state from Device/Group options

Fixed:

  • Typing for getEntityPublishPayload in OTAUpdate

@Nerivec
Copy link
Collaborator

Nerivec commented Oct 7, 2024

For 7b402b4

Removed:

  • /bridge/config/*
  • Settings in advanced:
    • availability_timeout
    • availability_blocklist
    • availability_passlist
    • availability_blacklist
    • availability_whitelist
    • soft_reset_timeout
    • report
  • Unused zigbee-herdsman wrapper API reset
  • Unused device API isIkeaTradfri
  • Unused utils

@Nerivec
Copy link
Collaborator

Nerivec commented Oct 7, 2024

I figure we do a separate PR at the end to cleanup all removed settings from settings.schema.json and the necessary changes in settings.ts?

@Nerivec
Copy link
Collaborator

Nerivec commented Oct 7, 2024

For 7f4e15f

Removed:

  • /bridge/configure
  • legacy_availability_payload setting
  • legacy_api setting
  • Legacy stuff from configure (previously missed, wasn't using legacy_api setting)

@Koenkk I'll let you do the stuff for HA. A search for legacy (whole-repo) should identify most remaining points.

@Koenkk Koenkk changed the base branch from dev to feat/2.0.0 October 11, 2024 21:30
@Koenkk
Copy link
Owner Author

Koenkk commented Oct 11, 2024

Removed some leftovers and create a PR for the docs: Koenkk/zigbee2mqtt.io#3094

Ready for merge?

@Koenkk Koenkk marked this pull request as ready for review October 11, 2024 21:30
@Koenkk Koenkk changed the title The big cleanup feat!: The big cleanup Oct 11, 2024
@Nerivec
Copy link
Collaborator

Nerivec commented Oct 12, 2024

There's the HA legacy stuff left to do. You're going to do that in a separate PR?

@Koenkk
Copy link
Owner Author

Koenkk commented Oct 12, 2024

Yes will do the HA stuff in a separate PR

@Nerivec

This comment was marked as resolved.

@Koenkk Koenkk merged commit f34f836 into feat/2.0.0 Oct 14, 2024
21 checks passed
@Koenkk Koenkk deleted the feat/the-big-cleanup branch October 14, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants