Option to use standard malloc for image load #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry but I don't want to merge workarounds. |
|
No prob! Will try to have a look at #407, because even some 2048x2048 pngs will fail to load now. (I guess stbi needs more mem to unpack) |
|
Yes, stbi allocs the complete target buffer plus some temporary allocations - haven't looked at the latter in detail yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to handle loading big images (exceeding BUFFER_SIZE) using standard allocators by defining
KINC_IMAGE_STANDARD_MALLOC.Related: #407