Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Point-and-Click Deletion for Fillets and Chamfers #5098

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

max-mrgrsk
Copy link
Collaborator

Description

This PR enhances user interaction by allowing fillets and chamfers to be deleted through point-and-click actions

Supports cases

  • Inside Pipes: Handles deletions within sketches, extrusions, and other pipes.
  • Outside Pipes: Enables deletion of standalone fillets and chamfers.

Implementation Details:

  • Encapsulated Logic: Moved deletion logic into the edgeTreatment code mod for better organization.
  • Integration: Utilized the deleteFromSelection function to invoke the encapsulated deletion process.

Closes: #5053

@max-mrgrsk max-mrgrsk linked an issue Jan 17, 2025 that may be closed by this pull request
Copy link

qa-wolf bot commented Jan 17, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@max-mrgrsk max-mrgrsk self-assigned this Jan 17, 2025
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 25, 2025 8:13am

@max-mrgrsk max-mrgrsk added the ast Issues / features relevant to ast and parser. label Jan 17, 2025
@max-mrgrsk max-mrgrsk added this to the v1 Modeling App Launch milestone Jan 17, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.08%. Comparing base (e7203b9) to head (145aea3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5098   +/-   ##
=======================================
  Coverage   86.08%   86.08%           
=======================================
  Files          89       89           
  Lines       32538    32538           
=======================================
  Hits        28011    28011           
  Misses       4527     4527           
Flag Coverage Δ
wasm-lib 86.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Issues / features relevant to ast and parser.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point-and-click deletion of fillets and chamfers
2 participants