-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Point-and-Click Deletion for Fillets and Chamfers #5098
base: main
Are you sure you want to change the base?
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…AD/modeling-app into max-click-delete-chamfers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5098 +/- ##
=======================================
Coverage 86.08% 86.08%
=======================================
Files 89 89
Lines 32538 32538
=======================================
Hits 28011 28011
Misses 4527 4527
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…AD/modeling-app into max-click-delete-chamfers
…AD/modeling-app into max-click-delete-chamfers
Description
This PR enhances user interaction by allowing
fillets
andchamfers
to be deleted through point-and-click actionsSupports cases
sketches
,extrusions
, and other pipes.standalone
fillets and chamfers.Implementation Details:
edgeTreatment
code mod for better organization.deleteFromSelection
function to invoke the encapsulated deletion process.Closes: #5053