Fix flaky playwright test 'Shell point-and-click sketch on face' #5002
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pierremtb
commented
Jan 10, 2025
Comment on lines
+1185
to
+1189
| await page.waitForTimeout(500) | ||
| await cmdBar.progressCmdBar() | ||
| await page.waitForTimeout(500) | ||
| await cmdBar.progressCmdBar() | ||
| await page.waitForTimeout(500) |
There was a problem hiding this comment.
More a workaround than a fix. But these two definitely help reducing the flakes locally on my ubuntu machine.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5002 +/- ##
=======================================
Coverage 85.84% 85.84%
=======================================
Files 88 88
Lines 31432 31432
=======================================
Hits 26984 26984
Misses 4448 4448
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lf94
approved these changes
Jan 10, 2025
pierremtb
deleted the
pierremtb/issue4998-Fix-flaky-playwright-test-Shell-point-and-click-sketch-on-face
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4998