Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Chromium instead of Chrome for Playwright Electron #5001

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Jan 10, 2025

This allows playwright electron tests to run on linux arm64, for which Chrome doesn't exist. If anything, this should also bring us closer to what Electron packages.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 10, 2025 6:12pm

Copy link

qa-wolf bot commented Jan 10, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@pierremtb pierremtb marked this pull request as ready for review January 10, 2025 18:10
@pierremtb pierremtb enabled auto-merge (squash) January 10, 2025 18:10
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (9334d64) to head (26ee6e8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5001   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files          88       88           
  Lines       31432    31432           
=======================================
  Hits        26984    26984           
  Misses       4448     4448           
Flag Coverage Δ
wasm-lib 85.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierremtb pierremtb merged commit 2b0ba37 into main Jan 10, 2025
30 checks passed
@pierremtb pierremtb deleted the pierremtb/playwright-electron-chromium branch January 10, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants