Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow orbit in sketch mode via setting #4990

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

nadr0
Copy link
Collaborator

@nadr0 nadr0 commented Jan 9, 2025

closes #4441

Issue

User wants the ability to rotate while in sketch mode

Implementation

  • Used camControls.enableRotate to allow disabling and enabling of the camera orbit while in sketch mode
  • Added a setting specifically for allowing orbit in sketch mode
  • When the user disables the orbit mode while in sketch mode it will sync their camera to the engine and lock their orbit

Testing

Tested several different workflows

  • Refresh app with setting on -> try sketching -> can rotate
  • Refresh app with setting off -> try sketching -> cannot rotate
  • Refresh app with setting on -> try sketching -> turn it off -> camera should sync and cannot rotate
  • Refresh app with setting off -> try sketching -> turn it on -> can rotate

Copy link

qa-wolf bot commented Jan 9, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 16, 2025 3:27pm

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (d4e9552) to head (47a766e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4990   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          88       88           
  Lines       31470    31475    +5     
=======================================
+ Hits        27062    27067    +5     
  Misses       4408     4408           
Flag Coverage Δ
wasm-lib 85.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierremtb
Copy link
Collaborator

Oh this is cool! Is it ready to review and merge @nadr0 ?

image

@nadr0
Copy link
Collaborator Author

nadr0 commented Jan 13, 2025

Oh this is cool! Is it ready to review and merge

Yes this should be ready for review.

Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested locally too 🔥 🚀

@pierremtb
Copy link
Collaborator

@nadr0 I think this test failure is real

image

@nadr0 nadr0 merged commit 842ef5e into main Jan 16, 2025
34 checks passed
@nadr0 nadr0 deleted the nadro/gh-4441/allow-orbit-in-sketch-mode branch January 16, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to orbit in sketch mode
2 participants