-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow orbit in sketch mode via setting #4990
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4990 +/- ##
=======================================
Coverage 85.99% 85.99%
=======================================
Files 88 88
Lines 31470 31475 +5
=======================================
+ Hits 27062 27067 +5
Misses 4408 4408
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Oh this is cool! Is it ready to review and merge @nadr0 ? |
Yes this should be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested locally too 🔥 🚀
@nadr0 I think this test failure is real |
closes #4441
Issue
User wants the ability to rotate while in sketch mode
Implementation
camControls.enableRotate
to allow disabling and enabling of the camera orbit while in sketch modeTesting
Tested several different workflows