Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add electron test for persisting open panes #3535

Merged
merged 9 commits into from
Aug 21, 2024
Merged

Conversation

jtran
Copy link
Collaborator

@jtran jtran commented Aug 19, 2024

Resolves #3390.

Checklist

  • Fix to not have test run order dependence. We now clear localStorage inside setup().

Copy link

qa-wolf bot commented Aug 19, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 20, 2024 10:13pm

@jtran jtran force-pushed the jtran/test-panes-projects branch from 80c5a29 to 09a5624 Compare August 20, 2024 15:25
@jtran jtran marked this pull request as ready for review August 20, 2024 15:26
@jessfraz
Copy link
Contributor

i think windows failure is related to file path stuff so merging

@jessfraz jessfraz disabled auto-merge August 21, 2024 02:11
@jessfraz jessfraz merged commit d14b8f5 into main Aug 21, 2024
20 of 24 checks passed
@jessfraz jessfraz deleted the jtran/test-panes-projects branch August 21, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron test: (regression) localstorage keeps the panes that were previously open, open
3 participants