Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes this reported issue, where the
convertKitRemoveSubscriberIDFromURL
method would not include any hash included in the URL.This bug was introduced in this PR (which introduced using
searchParams
to fetch URL query parameters, as a more reliable method to detect ack_subscriber_id
and other query parameters, but failed to fetch the URL hash), instead of the previous behaviour of grabbing the entire URL string.Testing
SubscriberIDURLCest
: Added tests and checks to existing tests to confirm the hash is included when specified, and no hash is appended if not in the URL.Checklist