Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Hash when included in URL #757

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Dec 18, 2024

Summary

Fixes this reported issue, where the convertKitRemoveSubscriberIDFromURL method would not include any hash included in the URL.

This bug was introduced in this PR (which introduced using searchParams to fetch URL query parameters, as a more reliable method to detect a ck_subscriber_id and other query parameters, but failed to fetch the URL hash), instead of the previous behaviour of grabbing the entire URL string.

Testing

  • SubscriberIDURLCest: Added tests and checks to existing tests to confirm the hash is included when specified, and no hash is appended if not in the URL.

Checklist

@n7studios n7studios added the bug label Dec 18, 2024
@n7studios n7studios self-assigned this Dec 18, 2024
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team December 18, 2024 15:19
@n7studios n7studios marked this pull request as ready for review December 18, 2024 15:19
@n7studios n7studios merged commit 66708ef into main Dec 18, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants