-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Fix _load_textdomain_just_in_time
PHP Notice
#747
Conversation
… into fix-cron-tests
…er-encoding-form-insertion
…isibility-support-non-inline-forms # Conflicts: # .github/workflows/tests.yml
… into fix-character-encoding-form-insertion
… into add-block-visibility-support-non-inline-forms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this still catch errors in the Kit plugin if it made this mistake?
It only suppresses the We load our language files correctly by using the |
…ine-forms Block Visibility: Support non-inline Forms
Fix character encoding when inserting Form after specific HTML element
Summary
WordPress 6.7 displays a PHP notice if a Theme or Plugin calls
load_plugin_textdomain
too early i.e. before the WordPressinit
hook and WP_DEBUG is enabled.This Plugin's tests run with WP_DEBUG enabled, and due to activating third party Plugins to run specific tests against, we get errors:
This PR resolves by suppressing the
_load_textdomain_just_in_time
PHP notice in our automated testing via use of a Plugin, whilst allowing other notices to still display and be detected.Also fixes cron tests failing due to a change in the admin UI URL in WP Crontrol 1.17.1, released November 23rd.
Testing
Existing tests pass.
Checklist