Categories: Forms: Change 'Default' value from -1 to 0 #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When defining the Form setting on Pages or Posts, key/value pairs have always been:
When defining the Form setting on a Category, key/value pairs were:
The 'None' label was misleading, because selecting this choice would display the Form specified at Post or Plugin level. This PR changed the Form setting value and its label on a Category to better reflect this:
However, this still isn't in line with Form settings on Pages and Posts, where Default is
-1
.This PR resolves by matching the Category Form settings with the Post Form settings:
Automatic upgrade routines are included to change existing Category settings to reflect this underlying change.
Testing
testCategoryDefaultSettingsMigratedToNewValueOnUpgrade
: Test that Category Form Settings = Default have their underlying value changed from0
to-1
Checklist