Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Forms from WP Rocket Minification / Combine #739

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Fixes this reported issue by registering the Kit hostnames to WP Rocket's rocket_minify_excluded_external_js filter, ensuring Forms are not minified by WP Rocket, resulting in them not displaying.

Testing

  • testFormBlockWithWPRocketPlugin: Renamed to testFormBlockWithWPRocketPluginDelayJS, to test that the Form displays when WP Rocket is set to delay JS.
  • testFormBlockWithWPRocketPluginMinifyJS: Test that the Form displays when WP Rocket is set to minify JS.
  • Created helper methods to configure WP Rocket, depending on the test.

Checklist

@n7studios n7studios added the bug label Nov 7, 2024
@n7studios n7studios self-assigned this Nov 7, 2024
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team November 8, 2024 09:43
@n7studios n7studios marked this pull request as ready for review November 8, 2024 09:43
@n7studios n7studios merged commit 8bd4d1f into main Nov 12, 2024
77 checks passed
@n7studios n7studios deleted the fix-wp-rocket-exclude-forms-minification branch November 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants