Broadcasts Importer: Refactor Functions #734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
ConvertKit_Broadcasts_Importer
class, making it possible to unit test theimport_broadcast
method.In the future, we'll likely mock the API call to the
wordpress/posts
endpoint in the WPUnit tests, to return a variety of different broadcast content to test the parsing and various configurations of theimport_broadcast
method.Testing
BroadcastsImportTest
: Added WPUnit tests against theimport_broadcast
method for the currently supported configurations.Checklist