Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasts Importer: Refactor Functions #734

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Refactors the ConvertKit_Broadcasts_Importer class, making it possible to unit test the import_broadcast method.

In the future, we'll likely mock the API call to the wordpress/posts endpoint in the WPUnit tests, to return a variety of different broadcast content to test the parsing and various configurations of the import_broadcast method.

Testing

  • BroadcastsImportTest: Added WPUnit tests against the import_broadcast method for the currently supported configurations.

Checklist

@n7studios n7studios changed the base branch from broadcasts-import-images to main October 29, 2024 09:21
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team October 31, 2024 06:19
@n7studios n7studios marked this pull request as ready for review October 31, 2024 06:19
@n7studios n7studios merged commit 95b0593 into main Nov 1, 2024
77 checks passed
@n7studios n7studios deleted the broadcasts-importer-refactor-functions branch November 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants