Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes this reported issue, due to the
maybe_tag_subscriber
method checking for an API Key and Secret, instead of an Access and Refresh Token.There are no other calls to
has_api_key_and_secret
, and this PR sets thehas_api_key_and_secret
method to deprecated, with it callinghas_access_and_refresh_token
and logging/displaying (depending on WordPress configuration) a notice for developers who might still be relying on this method:In the future, it's best to remove the
has_api_key_and_secret
method entirely, now it's no longer used.Testing
Tests failed to pick this up, as all tests would pre-populate the Plugin settings data in the database with an API Key and Secret, therefore ensuring that the
has_api_key_and_secret
condition passes.Removed pre-populating the Plugin settings data in the database with an API Key and Secret.
Checklist