Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Add Tag Functionality #732

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Fix Add Tag Functionality #732

merged 5 commits into from
Oct 28, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Fixes this reported issue, due to the maybe_tag_subscriber method checking for an API Key and Secret, instead of an Access and Refresh Token.

There are no other calls to has_api_key_and_secret, and this PR sets the has_api_key_and_secret method to deprecated, with it calling has_access_and_refresh_token and logging/displaying (depending on WordPress configuration) a notice for developers who might still be relying on this method:

Screenshot 2024-10-28 at 11 35 21

In the future, it's best to remove the has_api_key_and_secret method entirely, now it's no longer used.

Testing

Tests failed to pick this up, as all tests would pre-populate the Plugin settings data in the database with an API Key and Secret, therefore ensuring that the has_api_key_and_secret condition passes.

Removed pre-populating the Plugin settings data in the database with an API Key and Secret.

Checklist

@n7studios n7studios added the bug label Oct 28, 2024
@n7studios n7studios self-assigned this Oct 28, 2024
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team October 28, 2024 07:47
@n7studios n7studios marked this pull request as ready for review October 28, 2024 07:47
@n7studios n7studios merged commit b5f3b76 into main Oct 28, 2024
77 checks passed
@n7studios n7studios deleted the fix-add-tag-functionality branch November 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants