Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Only display Form Settings if Forms exist #731

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Only displays the Form Position setting if Forms exist on the Kit account.

Before:
Screenshot 2024-10-25 at 16 58 29

After:
Screenshot 2024-10-25 at 16 58 10

Testing

  • testSettingsScreenWhenNoResources: Test that Form setting options are not displayed when no Forms exist.

Checklist

@n7studios n7studios self-assigned this Oct 25, 2024
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team October 25, 2024 12:16
@n7studios n7studios marked this pull request as ready for review October 25, 2024 12:16
@n7studios n7studios merged commit 2b7139e into main Oct 28, 2024
77 checks passed
@n7studios n7studios deleted the conditionally-display-form-settings branch November 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants