Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing Tests #728

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Fix Failing Tests #728

merged 8 commits into from
Oct 23, 2024

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Oct 21, 2024

Summary

Fixes WPUnit tests, which have not run since this PR in August 2023, which split the test groups from acceptance/broadcast to acceptance/broadcasts/blocks-shortcodes and acceptance/broadcasts/import-export. As there's no acceptance/broadcasts test group, WPUnit tests never ran.

Fixes category and form tests failing due to using the incorrect convertkit.com, and a landing page test that was failing due to the introduction of the HTML lang attribute. These tests previously passed, so unsure if changes have been made on the Kit API / app or a migration run to switch over any errant convertkit.com references in forms.

Testing

Existing tests pass

Checklist

@n7studios n7studios self-assigned this Oct 21, 2024
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team October 22, 2024 00:41
@n7studios n7studios marked this pull request as ready for review October 22, 2024 00:41
@n7studios n7studios merged commit 2ae7346 into main Oct 23, 2024
77 checks passed
@n7studios n7studios deleted the fix-failing-tests branch November 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants