Broadcasts to Posts: Remove `get_by_key` method #571

n7studios · 2023-10-20T13:23:44Z

Summary

Removes the get_by_key method for Broadcasts, as named methods are preferred in case array key names change in the future.

Existing tests pass.

I have written a test and included it in this PR
I have run all tests and they pass
The code passes when running the PHP CodeSniffer
Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
Security and Sanitization requirements have been followed
I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Named methods are preferred in case array key names change in the future

Remove get_by_key method

cb4f34b

Named methods are preferred in case array key names change in the future

n7studios added the enhancement label Oct 20, 2023

n7studios self-assigned this Oct 20, 2023

Fix syntax error

dd92078

n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team October 20, 2023 14:14

n7studios marked this pull request as ready for review October 20, 2023 14:14

noelherrick approved these changes Oct 23, 2023

View reviewed changes

n7studios merged commit 970266c into main Oct 23, 2023

n7studios deleted the broadcast-import-remove-get-by-key-function branch October 23, 2023 16:32