Skip to content

Commit

Permalink
Merge pull request #453 from ConvertKit/wp-6.2
Browse files Browse the repository at this point in the history
Run tests against ‘latest’ (WordPress 6.2)
  • Loading branch information
n7studios authored Mar 30, 2023
2 parents b4cc10f + 2181270 commit 45c30dd
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/coding-standards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
# Defines the WordPress and PHP Versions matrix to run tests on.
strategy:
matrix:
wp-versions: [ '6.2-RC2' ] #[ '6.1.1', 'latest' ]
wp-versions: [ 'latest' ] #[ '6.1.1', 'latest' ]
php-versions: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ] #[ '7.3', '7.4', '8.0', '8.1' ]

# Steps to install, configure and run tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
# For PHP, make sure that an nginx configuration file exists for the required PHP version in this repository at tests/nginx/php-x.x.conf
strategy:
matrix:
wp-versions: [ '6.2-RC4' ] #[ '6.1.1', 'latest' ]
wp-versions: [ 'latest' ] #[ '6.1.1', 'latest' ]
php-versions: [ '7.4', '8.0', '8.1', '8.2' ] #[ '7.4', '8.0', '8.1' ]

# Folder names within the 'tests' folder to run tests in parallel.
Expand Down
2 changes: 1 addition & 1 deletion readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Contributors: nathanbarry, growdev, travisnorthcutt, ggwicz
Donate link: https://convertkit.com
Tags: email marketing, email newsletter, newsletter, subscribers, convertkit
Requires at least: 5.0
Tested up to: 6.1.1
Tested up to: 6.2
Requires PHP: 5.6.20
Stable tag: 2.1.1
License: GPLv2 or later
Expand Down
7 changes: 6 additions & 1 deletion tests/_support/Helper/Acceptance/Plugin.php
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@ public function setupConvertKitPluginResources($I)
'name' => 'gravityforms-tag-1',
'created_at' => '2022-02-02T14:06:32.000Z',
],
3748541 => [
'id' => 3748541,
'name' => 'wpforms',
'created_at' => '2023-03-29T12:32:38.000Z',
],
2907193 => [
'id' => 2907193,
'name' => 'gravityforms-tag-2',
Expand Down Expand Up @@ -577,7 +582,7 @@ public function checkSelectTagOptionOrder($I, $selectElement, $prependOptions =
// Define options.
$options = [
'gravityforms-tag-1', // First item.
'wordpress', // Last item.
'wpforms', // Last item.
];

// Prepend options, such as 'Default' and 'None' to the options, if required.
Expand Down
6 changes: 3 additions & 3 deletions tests/wpunit/ResourceTagsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public function testGet()

// Assert order of data is in ascending alphabetical order.
$this->assertEquals('gravityforms-tag-1', reset($result)[ $this->resource->order_by ]);
$this->assertEquals('wordpress', end($result)[ $this->resource->order_by ]);
$this->assertEquals('wpforms', end($result)[ $this->resource->order_by ]);
}

/**
Expand Down Expand Up @@ -166,7 +166,7 @@ public function testGetWithValidOrderByAndOrder()
$this->assertArrayHasKey('name', reset($result));

// Assert order of data is in ascending alphabetical order.
$this->assertEquals('wordpress', reset($result)[ $this->resource->order_by ]);
$this->assertEquals('wpforms', reset($result)[ $this->resource->order_by ]);
$this->assertEquals('gravityforms-tag-1', end($result)[ $this->resource->order_by ]);
}

Expand Down Expand Up @@ -197,7 +197,7 @@ public function testGetWithInvalidOrderBy()

// Assert order of data has not changed.
$this->assertEquals('wordpress', reset($result)['name']);
$this->assertEquals('gravityforms-tag-2', end($result)['name']);
$this->assertEquals('wpforms', end($result)['name']);
}

/**
Expand Down

0 comments on commit 45c30dd

Please sign in to comment.