Added null safety support #26
Conversation
dpr10
commented
Mar 18, 2021
dpr10
commented
- updated example app
- updated android embed version
- migrate to androidX
- updated android embed version - updated example app - used androidX on example app
added null safety support
|
Closes #23. |
|
Definitely need this |
- updated example - updated version according null safety migration guide
|
PR updated. Thanks @friebetill |
|
please complete and merge this PR. thanks |
|
As far as I can see, the PR is complete. @KingWu just needs to look over it. In the meantime you can already use the PR with the following in your dev_dependencies:
...
# Waiting for this PR https://bit.ly/3tO37NG
gen_lang:
git:
url: https://github.com/KingWu/gen_lang
ref: 7ba7548
... |
|
@KingWu we definitely need this, also to solve version issues , mainly with some packages depending on |
|
no activity of the author since september and last version May 2, 2020. :/ hopefully the activity will be changed to active. |
|
Any progression on this? Please just approve it! @KingWu or someone else? |
| var parser = new ArgParser(); | ||
|
|
||
| parser.addOption('source-dir', | ||
| defaultsTo: 'res/string', | ||
| callback: (String x) => i18nOption.sourceDir = x, | ||
| callback: (String? x) => i18nOption!.sourceDir = x, |
There was a problem hiding this comment.
if (I18nOption == null) this will throw an error
| help: 'A source folder contains all string json files'); | ||
|
|
||
| parser.addOption('output-dir', | ||
| defaultsTo: 'lib/generated', | ||
| callback: (String x) => i18nOption.outputDir = x, | ||
| callback: (String? x) => i18nOption!.outputDir = x, |
There was a problem hiding this comment.
if (I18nOption == null) this will throw an error
| help: 'A output folder stores all generated files'); | ||
|
|
||
| parser.addOption('template-locale', | ||
| defaultsTo: 'en', | ||
| callback: (String x) => i18nOption.templateLocale = x, | ||
| callback: (String? x) => i18nOption!.templateLocale = x, |
There was a problem hiding this comment.
if (I18nOption == null) this will throw an error
|
Now that Dart 3 forces the use of Null Safety, it would be a good time to complete this PR 😄 |
