Upgrade Dependencies and change packaging tooling #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded to Ansible 8.2.0 - Changed from [pipenv][] to [pdm][] and `pyproject.toml` because of ongoing issues with Dependabot not detecting dependencies in `Pipfile.lock` as opposed to only in `requirements.txt` (the inverse of dependabot/dependabot-core#6200). After trying Poetry (predates the latest Python packaging PEPs), rye (experimental), and hatch (no lock file), [pdm][] seems to fit the bill best for the limited needs that we have with this project. - Experimentally removed the generated `requirements.txt` file. It isn't used, but it has been valuable in getting update notifications from Dependabot, although the update PRs are less useful. If required, we can add it back with `pdm export -f requirements > requirements.txt`.
halostatue
changed the title
mikestok
approved these changes
Aug 4, 2023
Autogenerated, so… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to Ansible 8.2.0
Changed from pipenv to pdm and
pyproject.tomlbecause of ongoing issues with Dependabot not detecting dependencies inPipfile.lockas opposed to only inrequirements.txt(the inverse of Dependabot fails to update same dependency in same pull request dependabot/dependabot-core#6200). After trying Poetry (predates the latest Python packaging PEPs), rye (experimental), and hatch (no lock file), pdm seems to fit the bill best for the limited needs that we have with this project.Experimentally removed the generated
requirements.txtfile. It isn't used, but it has been valuable in getting update notifications from Dependabot, although the update PRs are less useful. If required, we can add it back withpdm export -f requirements > requirements.txt.