Skip to content

Commit

Permalink
Try a pure UV build again, using hidden import. Might need to go back…
Browse files Browse the repository at this point in the history
… to pip
  • Loading branch information
scosman committed Oct 31, 2024
1 parent 904aa8d commit 2aa7190
Show file tree
Hide file tree
Showing 3 changed files with 92 additions and 102 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/build_desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,24 +20,14 @@ jobs:
with:
enable-cache: true

- uses: actions/setup-python@v5
with:
python-version: 3.12
cache: "pip"

- name: Set up Python
run: uv python install

- name: Install the project
run: uv sync

- name: generate requirements.txt
run: uv pip freeze > requirements.txt

- run: pip install -r requirements.txt

# Compress MacOS app param ignored on Windows
- run: sh ./app/desktop/build_desktop_app.sh --compress-mac-app
- run: uv run sh ./app/desktop/build_desktop_app.sh --compress-mac-app
- uses: actions/upload-artifact@v4
with:
name: kiln-desktop-${{ runner.os }}-${{ runner.arch }}
Expand Down
2 changes: 1 addition & 1 deletion app/desktop/build_desktop_app.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ fi
# TODO: use a spec instead of long winded command line
pyinstaller $(printf %s "$PLATFORM_OPTS") --icon="./icon.png" \
--add-data "./taskbar.png:." --add-data "../../web_ui/build:./web_ui/build" \
--noconfirm --distpath=./desktop/build/dist --workpath=./desktop/build/work \
--noconfirm --hidden-import "tkinter" --distpath=./desktop/build/dist --workpath=./desktop/build/work \
-n Kiln --specpath=./desktop/build \
--paths=. ./desktop/desktop.py

Expand Down
Loading

0 comments on commit 2aa7190

Please sign in to comment.