Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial submit of WEBGL_multisampled_render_to_texture proposal #3342

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cabanier
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2021

CLA assistant check
All committers have signed the CLA.

@cabanier cabanier marked this pull request as ready for review October 11, 2021 18:17
Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. A few issues to be addressed.

@@ -0,0 +1,160 @@
<?xml version="1.0"?>

<extension href="WEBGL_multisampled_render_to_texture/">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run "make" under the extensions/ directory and fix the errors generated. At least this href is incorrect; there may be others.

"use strict";

let wtu = WebGLTestUtils;
let gl = wtu.create3DContext(null, null, 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the extension is written against the WebGL 1.0 specification, this test should be placed in conformance/extensions/ rather than conformance2/extensions/. In that case the create3DContext call should not specify a context version as its third argument.

@@ -0,0 +1,181 @@
<!--
Copyright (c) 2019 The Khronos Group Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021

@@ -0,0 +1,181 @@
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add any new tests to 00_test_list.txt in the same directory.

For WebGL 1.0 tests, use --min-version 1.0.4.

For WebGL 2.0 tests, use --min-version 2.0.1.

@kdashg
Copy link
Contributor

kdashg commented Nov 4, 2021

I would prefer not to add more WebGL 1 extensions anymore, now that all UAs have WebGL2. (And any machine that we support this ext on would support webgl2)

epreston added a commit to epreston/renderlayer that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants