Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bikeshedding on WEBGL_video_texture #2718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kainino0x
Copy link
Contributor

This is a placeholder PR for bikeshedding on WEBGL_video_texture. I've suggested a rename here, because I think the old one was confusing.

I like something like this because it retains the "texImage2D" heritage. Without it, it's not clear that this behaves much like an upload call. However I'm open to other ideas.

This is a placeholder PR for bikeshedding on WEBGL_video_texture. I've suggested a rename here, because I think the old one was confusing.

I like something like this because it retains the "texImage2D" heritage. Without it, it's not clear that this behaves much like an upload call. However I'm open to other ideas.
@kenrussell
Copy link
Member

Good suggestion. I like it, but one concern is that with the texImage2D naming, users may think it acts like a copy. Maybe wording involving "latch video texture" or similar could help.

Ultimately we'll also need to respecify this so that the reference to the video texture is only live during the current requestAnimationFrame callback, or similar.

@MarkCallow
Copy link
Collaborator

Without it, it's not clear that this behaves much like an upload call

Maybe wording involving "latch video texture" or similar could help.

Because of the latch video behavior, this function really does not behave much like an upload call.

@kainino0x
Copy link
Contributor Author

With the original name, I was concerned with making sure it doesn't sound like the texture always tracks the video, latching rather than always magically "referring to" the most recent frame.

@kainino0x
Copy link
Contributor Author

(But yes, it's important to distinguish it from an "upload"/copy as well.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants