layers: Validate binary sync depenency on timeline wait #8739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This validates "and any semaphore signal operations on which it depends must have also been submitted for execution" from these VUIDs: VUID-vkQueueSubmit-pWaitSemaphores-03238 VUID-vkQueueSubmit2-semaphore-03873 VUID-vkQueuePresentKHR-pWaitSemaphores-03268 VUID-VkSemaphoreGetFdInfoKHR-handleType-03254
|
CI Vulkan-ValidationLayers build queued with queue ID 284488. |
|
CI Vulkan-ValidationLayers build # 17799 running. |
artem-lunarg
changed the title
artem-lunarg
force-pushed
the
artem-issue-8707
branch
from
61052b8
to
2d389ad
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 284550. |
|
CI Vulkan-ValidationLayers build # 17800 running. |
|
CI Vulkan-ValidationLayers build # 17800 aborted. |
|
CI Vulkan-ValidationLayers build queued with queue ID 284712. |
|
CI Vulkan-ValidationLayers build # 17805 running. |
|
CI Vulkan-ValidationLayers build # 17805 failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partiallyaddresses #8707What's left for other PRs:
VUID-vkQueueSubmit-pWaitSemaphores-03238: either missing binary signal or binary signal exists but depends on timeline wait.Try to analyze entire synchronization chain, not only direct parent.- actually this works, added one more test to show thisNegativeSyncObject.BinarySyncDependsOnTimelineWait3.