Skip to content

Commit

Permalink
correct failed output for direct_state_access.buffers_clear
Browse files Browse the repository at this point in the history
For R8* formats, the data is interpreted as non-integer, so it messes
with the log output. This change ensures the numbers are produced.

Current outcome for R8* formats failure:
The test of ClearNamedBufferData has failed for internalformat . Cleared buffer data is equal to [

After the fix:
The test of ClearNamedBufferData has failed for internalformat . Cleared buffer data is equal to [0], but [5] was expected.

Affects:
KHR-GL46.direct_state_access.buffers_clear

Change-Id: I9e9d771ba129464824df258d5a7066ac797b4c3a
Signed-off-by: David Heidelberg <[email protected]>
  • Loading branch information
okias committed Jul 17, 2024
1 parent 5b2dfe7 commit 20c9063
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ void ClearTest::LogFail(bool use_sub_data, glw::GLenum internalformat, const T *
{
std::stringstream number;

number << data[i];
number << (GLint)data[i];

the_log.append(number.str());

Expand All @@ -810,7 +810,7 @@ void ClearTest::LogFail(bool use_sub_data, glw::GLenum internalformat, const T *
{
std::stringstream number;

number << reference[i];
number << (GLint)reference[i];

the_log.append(number.str());

Expand Down

0 comments on commit 20c9063

Please sign in to comment.