Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rephrase and correct the descriptions for clSetKernelExecInfo #1245

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Aug 29, 2024

fixes #1152
fixes #1244

Rephrases and corrects the descriptions for multiple parts of clSetKernelExecInfo.

Removes the cumbersome "note" below the API description and moves the content into the API description instead. I don't think I lost any important content, but this would be a good area for a careful review.

Explicitly states that an empty set of SVM pointers for CL_KERNEL_EXEC_INFO_SVM_PTRS is valid.

@bashbaug
Copy link
Contributor Author

Depending how we resolve #1244 we may need to make additional clarifications.

@bashbaug
Copy link
Contributor Author

bashbaug commented Sep 3, 2024

Converting to draft to work out system SVM updates.

@bashbaug bashbaug marked this pull request as draft September 3, 2024 16:43
clarify that CL_KERNEL_EXEC_INFO_SVM_FINE_GRAIN_SYSTEM does not
affect kernel arguments
@bashbaug
Copy link
Contributor Author

bashbaug commented Sep 4, 2024

This is ready for review again.

@bashbaug bashbaug marked this pull request as ready for review September 4, 2024 05:27
@bashbaug bashbaug mentioned this pull request Oct 22, 2024
30 tasks
Copy link
Contributor

@karolherbst karolherbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bashbaug
Copy link
Contributor Author

Merging (offline) as discussed in the October 22nd teleconference.

@bashbaug bashbaug merged commit 1c3c918 into KhronosGroup:main Oct 23, 2024
2 checks passed
@bashbaug bashbaug deleted the clarify-clSetKernelExecInfo branch October 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants