-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning now treated as error #2107
Conversation
Following the re-enablement of narrowing warnings, this fixes a compilation error when running the `ubuntu 22.04 arm` GitHub action. Signed-off-by: Ahmed Hesham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-controversial, merging immediately.
(Is this something we could/should have caught in CI?)
@bashbaug Thank you for the quick review and merge. I think the problem was that the pull request had passed all the CI checks when it was merged, the compilation error was a from a file that was added after that point. I don't think it would have been caught by the CI except if we had asked to rerun the checks before merging (not unreasonable but will not likely scale well with the volume of pull requests we have open). |
This change breaks 32 bit builds (built on x86_64 linux with -m32):
Do you need an issue created or do you want to just fix the new error? As a side-note we have had other 32 bit fails for similar reasons - should we add 32 bit x86_64 build? (+test?) |
Are you sure this change breaks your build? The error you pasted seems to reference the original code before this fix is applied. |
Ah yes, I think you are right, we saw a fail last night and i checked the latest commits. My apologies. |
Following the re-enablement of narrowing warnings, this fixes a compilation error when running the
ubuntu 22.04 arm
GitHub action.