Added test for work-item functions with out-of-range arguments #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvh
reviewed
Oct 25, 2024
|
|
||
| for (size_t dim = 1; dim <= 3; dim++) | ||
| { | ||
| cl_uint local_workgroup_size[3] = { maxWorkItemSizes[0], |
There was a problem hiding this comment.
Suggested change
| cl_uint local_workgroup_size[3] = { maxWorkItemSizes[0], | |
| size_t local_workgroup_size[3] = { maxWorkItemSizes[0], |
?
(to avoid narrowing conversion warnings on latest main)
| outOfRangeWorkItemKernelCode) | ||
| {} | ||
|
|
||
| virtual cl_int SetUp(const char *kernel_source) override |
There was a problem hiding this comment.
Suggested change
| virtual cl_int SetUp(const char *kernel_source) override | |
| cl_int SetUp(const char *kernel_source) override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to description from issue #2005