Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing test cases for CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR queries #2063

Merged

Conversation

shajder
Copy link
Contributor

@shajder shajder commented Aug 29, 2024

According to comments from issue #1875

@shajder shajder closed this Sep 12, 2024
@shajder
Copy link
Contributor Author

shajder commented Sep 12, 2024

close/open to retrigger CI

@shajder shajder reopened this Sep 12, 2024
@joshqti
Copy link
Contributor

joshqti commented Oct 8, 2024

We are OK with this change

Copy link
Contributor

@nikhiljnv nikhiljnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bashbaug
Copy link
Contributor

Merging as discussed in the October 15th teleconference.

@bashbaug bashbaug merged commit 2998463 into KhronosGroup:main Oct 15, 2024
7 checks passed
@bashbaug bashbaug deleted the semaphore_device_handle_list_complement branch October 15, 2024 15:44
svenvh pushed a commit that referenced this pull request Oct 16, 2024
…rms (#2117)

Looks like #2063 has a
"narrowing" warning that is now treated as an error and is hence causing
CI builds to fail.

Applies the same fix as
#2107 to fix this
warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants