Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for clCommandSVMMemcpyKHR & clCommandSVMMemfillKHR #1821

Merged
merged 5 commits into from
Oct 10, 2023
Merged

add tests for clCommandSVMMemcpyKHR & clCommandSVMMemfillKHR #1821

merged 5 commits into from
Oct 10, 2023

Conversation

franz
Copy link
Contributor

@franz franz commented Sep 26, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@franz franz mentioned this pull request Sep 26, 2023
Merged
@franz
Copy link
Contributor Author

franz commented Sep 26, 2023

error: ‘clCommandSVMMemfillKHR’ was not declared in this scope

CI is failing because it's missing cl_ext.h counterpart of this PR

EwanC
EwanC previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things but LGTM. I've not tried this patch against an implementation that supports this, but it skips correctly for a command-buffer implementation without SVM.

test_conformance/extensions/cl_khr_command_buffer/svm_command_basic.cpp Show resolved Hide resolved
test_conformance/extensions/cl_khr_command_buffer/svm_command_basic.cpp Outdated Show resolved Hide resolved
test_conformance/extensions/cl_khr_command_buffer/svm_command_basic.cpp Outdated Show resolved Hide resolved
bashbaug
bashbaug reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I've added support for these functions to the command buffer emulation layer and these news tests are passing.

test_conformance/extensions/cl_khr_command_buffer/svm_command_basic.cpp Outdated Show resolved Hide resolved
test_conformance/extensions/cl_khr_command_buffer/svm_command_basic.cpp Outdated Show resolved Hide resolved
@bashbaug
Copy link
Contributor

Merging as discussed in the October 10th teleconference.

@bashbaug bashbaug merged commit af27103 into KhronosGroup:main Oct 10, 2023
7 checks passed
@bashbaug bashbaug mentioned this pull request Oct 10, 2023
Merged
@franz franz deleted the cl_command_buffer_svm branch October 20, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug left review comments

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franz @CLAassistant @bashbaug @EwanC