-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulkan: Use linear tiling #1559
Vulkan: Use linear tiling #1559
Conversation
3491ae3
to
a9449ac
Compare
#1530 has disabled these tests in CMake by default. |
HI Nikhil, We do want to build and run these tests. Our recommendation is that supporting interop of Linear tiled Vulkan images with OpenCL is sufficient for an implementation to be conformant. Thanks, |
Hi Balaji, |
Hi Nikhil, We are ok with adding an option for testing optimally tiled images as long as the default is linear. Should we update the PR with that option? Thanks, |
If it is a small change, prefer to do it as part of this PR. Otherwise, we can file a separate issue and/or fix it in a subsequent PR. |
We don't say anything about tiling requirements in the external memory extension specification. Should we? |
I have filed KhronosGroup/OpenCL-Docs#861 to track the spec discussions and required changes to the spec. |
The external memory sharing spec does not require OpenCL to deduce if a Vulkan image is tiled or linear. Use linear images. Additionally, when selecting a queue family, the Vulkan implementation is not required to report the transfer bit for compute or graphics queues, it is implied.
The external memory sharing spec does not require OpenCL to deduce if a Vulkan image is tiled or linear. Use linear images by default and add a parameter to test optimal images. Additionally, when selecting a queue family, the Vulkan implementation is not required to report the transfer bit for compute or graphics queues, it is implied.
a9449ac
to
abad7ee
Compare
Removing "focused review" while we figure out KhronosGroup/OpenCL-Docs#861. |
We will update this test as per final resolution of KhronosGroup/OpenCL-Docs#861 |
Ping @lakshmih !! Is this still needed? If not, can we close? |
The external memory sharing spec does not require
OpenCL to deduce if a Vulkan image is tiled or linear. Use tiled images.
Additionally, when selecting a queue family, the Vulkan implementation is not required to report the transfer bit for compute or graphics queues, it is implied.