Merge branch 'MaaAssistantArknights:dev' into dev
1021 new problems found by Qodana for .NET
Qodana for .NET
901 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Redundant using directive |
🔶 Warning | 392 |
Unknown property |
🔶 Warning | 59 |
Method return value is never used (private accessibility) |
🔶 Warning | 57 |
Possible 'System.NullReferenceException' |
🔶 Warning | 21 |
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. |
🔶 Warning | 18 |
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 18 |
Async method invocation without await expression |
🔶 Warning | 17 |
Usage of <inheritdoc /> is invalid |
🔶 Warning | 10 |
Conditional access qualifier expression is known to be null or not null |
🔶 Warning | 5 |
Access to modified captured variable |
🔶 Warning | 4 |
Bitwise operation on enum is not marked by [Flags] attribute |
🔶 Warning | 4 |
Code is unreachable |
🔶 Warning | 4 |
Rider toolset and environment errors |
🔶 Warning | 4 |
Redundant type declaration body |
🔶 Warning | 1 |
Local function return value is never used |
🔶 Warning | 1 |
Type member is never used (private accessibility) |
🔶 Warning | 1 |
Unused local variable |
🔶 Warning | 1 |
Use preferred namespace body style |
◽️ Notice | 75 |
Method return value is never used (non-private accessibility) |
◽️ Notice | 74 |
Type member is never used (non-private accessibility) |
◽️ Notice | 49 |
Member can be made private (non-private accessibility) |
◽️ Notice | 19 |
RoslynAnalyzers Mark members as static |
◽️ Notice | 12 |
RoslynAnalyzers Non-constant fields should not be visible |
◽️ Notice | 11 |
Non-accessed field (non-private accessibility) |
◽️ Notice | 11 |
Some values of the enum are not processed inside 'switch' statement and are handled via default section |
◽️ Notice | 9 |
Use preferred style of 'new' expression when created type is evident |
◽️ Notice | 5 |
Type is never used (non-private accessibility) |
◽️ Notice | 5 |
Convert constructor into primary constructor |
◽️ Notice | 3 |
Inline temporary variable |
◽️ Notice | 3 |
Overlapping sections |
◽️ Notice | 2 |
Unused parameter (non-private accessibility) |
◽️ Notice | 2 |
RoslynAnalyzers Do not assign a property to itself |
◽️ Notice | 1 |
Class is never instantiated (non-private accessibility) |
◽️ Notice | 1 |
Event is never subscribed to (non-private accessibility) |
◽️ Notice | 1 |
Some values of the enum are not processed inside 'switch' statement |
◽️ Notice | 1 |
View the detailed Qodana report
To be able to view the detailed Qodana report, you can either:
- Register at Qodana Cloud and configure the action
- Use GitHub Code Scanning with Qodana
- Host Qodana report at GitHub Pages
- Inspect and use
qodana.sarif.json(see the Qodana SARIF format for details)
To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:
- name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 496 in src/MaaWpfGui/ViewModels/UI/TaskQueueViewModel.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 497 in src/MaaWpfGui/ViewModels/UI/TaskQueueViewModel.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 495 in src/MaaWpfGui/ViewModels/UI/TaskQueueViewModel.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 498 in src/MaaWpfGui/ViewModels/UI/TaskQueueViewModel.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check notice on line 15 in src/MaaWpfGui/Utilities/ValueType/GenericCombinedData.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 28 in src/MaaWpfGui/Configuration/ConfigFactory.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 23 in src/MaaWpfGui/Services/Web/MaaApiService.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 19 in src/MaaWpfGui/Styles/Controls/TextBlock.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 44 in src/MaaWpfGui/ViewModels/UI/TaskQueueViewModel.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 18 in src/MaaWpfGui/Models/StageActivityInfo.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 30 in src/MaaWpfGui/Services/Web/HttpService.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 28 in src/MaaWpfGui/Helper/MessageBoxHelper.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 28 in src/MaaWpfGui/Models/ResourceUpdater.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 22 in src/MaaWpfGui/Helper/WinAdapter.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 22 in src/MaaWpfGui/Styles/Properties/ScrollViewerBinding.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 18 in src/MaaWpfGui/Services/Web/IMaaApiService.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 15 in src/MaaWpfGui/Utilities/ValueType/CombinedData.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 19 in src/MaaWpfGui/Helper/WindowHandle.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 18 in src/MaaWpfGui/Models/WindowPlacement.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 37 in src/MaaWpfGui/ViewModels/UI/CopilotViewModel.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 20 in src/MaaWpfGui/ViewModels/UI/AnnouncementViewModel.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 21 in src/MaaWpfGui/Models/TaskSettingVisibilityInfo.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 21 in src/MaaWpfGui/Services/Web/IHttpService.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 56 in src/MaaWpfGui/ViewModels/UI/SettingsViewModel.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace
Check notice on line 38 in src/MaaWpfGui/ViewModels/UI/VersionUpdateViewModel.cs
github-actions / Qodana for .NET
Use preferred namespace body style
Convert to file-scoped namespace