-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ Added tests for starknet_simulate_transactions and bump starknet.rs version to maintain compatibility with Deoxys #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding simulate transaction type for Ditto test, TODO : Add constant
antiyro
reviewed
Jan 11, 2024
…nsactions.rs to lib.rs Transfert simulate_transactions utils from test_simulate_transactions.rs to lib.rs for a better code format
antiyro
reviewed
Jan 11, 2024
Changing tests results for better reliability
bump starknet.rs version to maintain compatibility with Deoxys
Last commit resolve #30 |
formated code
Tbelleng
changed the title
✅ Added tests for starknet_simulate_transactions
✅ Added tests for starknet_simulate_transactions and bump starknet.rs version to maintain compatibility with Deoxys
Jan 11, 2024
Syncing with re4cents PR
fmt
antiyro
reviewed
Jan 12, 2024
antiyro
reviewed
Jan 12, 2024
Improve code format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding following tests for simulate_transactions call
fail_non_existing_block
fail_max_fee_too_big
fail_if_one_txn_cannot_be_executed
works_ok_on_no_validate
works_ok_on_validate_with_signature
works_ok_on_validate_without_signature_with_skip_validate