chore(deps): update k8s deps #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the following kubernetes dependencies together, doing that on an individual level will cause everything to break - apimachinery - client-go - controller-runtime The update to latest version of controller-runtime required some changes to the code used to initialize our `Manager`, more specifically to the configuration options: * `Port`: this was the port used by the webhook server ran by the controller. The option is gone now, given we don't have a webhook endpoint I just removed that. * `MetricsAddress`: this has now been moved under `Metrics`, which holds the configuration of the metrics server. I've moved the configuration over there * Namespace: this option is gone. Now there's a more flexible (and IMHO confusing) way to configure the cache of the Kubernetes client. I've adapted the init code to achieve the same result as before: ensure only resources under the `kwasm` Namespace are watched. Cluster-wide resources, like Node, are not affected by this change; everything stays the same for them Signed-off-by: Flavio Castelli <[email protected]>
This was referenced Dec 4, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the following kubernetes dependencies together, doing that on an individual level will cause everything to break
The update to latest version of controller-runtime required some changes to the code used to initialize our
Manager, more specifically to the configuration options:Port: this was the port used by the webhook server ran by the controller. The option is gone now, given we don't have a webhook endpoint I just removed that.MetricsAddress: this has now been moved underMetrics, which holds the configuration of the metrics server. I've moved the configuration over therekwasmNamespace are watched. Cluster-wide resources, like Node, are not affected by this change; everything stays the same for them