fix(build): make image tag lowecase #43
Conversation
0xE282B0
force-pushed
the
fix_push-action
branch
2 times, most recently
from
c608ff3 to
b24ad6e
Compare
|
@flavio, do you know if there is a nicer way to lowercase the |
0xE282B0
force-pushed
the
fix_push-action
branch
from
b24ad6e to
d7ba5d3
Compare
There was a problem hiding this comment.
@0xE282B0 I didn't find any built-in function for that by looking at the documentation over there.
I'm fine with your proposal, but I made another one in the comments.
BTW, I'm sorry I didn't see that coming with my tests :(
| @@ -53,6 +53,12 @@ jobs: | |||
| if: ${{ startsWith(github.ref, 'refs/tags/') }} | |||
| run: | | |||
| echo TAG_NAME=$(echo $GITHUB_REF | sed -e "s|refs/tags/||") >> $GITHUB_ENV | |||
There was a problem hiding this comment.
What about reusing this step and do something like:
| echo TAG_NAME=$(echo $GITHUB_REF | sed -e "s|refs/tags/||") >> $GITHUB_ENV | |
| echo TAG_NAME=$(echo $GITHUB_REF | sed -e "s|refs/tags/||") >> $GITHUB_ENV | |
| echo REPOSITORY_NAME=$(echo {{ github.repository_owner }} | awk "{print tolower($0)}")) >> $GITHUB_ENV |
I didn't try it on GH, but I think it should work and would just reduce the number of steps and keep things consistent
There was a problem hiding this comment.
It still feels odd that it takes so many changes to fix it.
But at least it is consistent and less steps.
There was a problem hiding this comment.
BTW, I'm sorry I didn't see that coming with my tests :(
No worries, you tested everything else on your fork 😊.
0xE282B0
force-pushed
the
fix_push-action
branch
2 times, most recently
from
aa36f90 to
438889f
Compare
Signed-off-by: Sven Pfennig <[email protected]>
0xE282B0
force-pushed
the
fix_push-action
branch
from
438889f to
6090c7e
Compare
No description provided.