Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable coverage #342

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

techman83
Copy link
Member

Renables coverage, any issues I'll debug and ensure my fork with open PR is up to date.

@techman83
Copy link
Member Author

Double checked where I worked on this feature and it still works. I have changed to the 'demo' branch, but checking both the feat/demo branches are on the same commits

If something doesn't work, I'll fix it.

Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If something doesn't work, I'll fix it.

Alright, brace for impact...!

@HebaruSan HebaruSan merged commit 8f6392c into KSP-CKAN:master Sep 19, 2024
3 checks passed
@HebaruSan
Copy link
Member

HebaruSan commented Sep 19, 2024

@techman83, should something have happened with this after merge? If so, then it looks like the first thing to fix will be getting it to run at all:

https://github.com/KSP-CKAN/NetKAN-Infra/actions/workflows/coverage-report.yml

image

... looks like coverage-build only runs when a PR is submitted, so I guess this is as-designed, and we'll have to wait for the next PR to test it?

on:
pull_request:
branches:
- master

@techman83 techman83 deleted the feat/enable-coverage branch September 20, 2024 00:28
@techman83
Copy link
Member Author

That's expected. The workflow needs to exist in the default branch before it can run. This is to prevent someone skirting security by raising a PR that has a workflow that triggers a workflow within the repo, that would have extra permissions it wouldn't ordinarily get. It's why I had to write the changes in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants