Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/KILTprotocol/ticket/issues/3752.
I realized I over-complicated the previous solution. We never ever have considered the total size of a storage map in our benchmarks, so I don't see why we would need to start now.
In our case, the deletion hook has the worst case if it returns
true
, which is the default behaviour, hence we don't need any specialsetup
logic for the benchmarks. If needed in the future, that is easy to add behind afeature = "runtime-benchmarks"
cfg instruction.This solution simplifies weight computation by a lot, since the additional weight will be considered when running the benchmarks already, and does not need any specialised benchmarking logic.